Attempt to make type inference checks more robust #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add is_inferred(), which mirrors most of the functionality of code_warntype(), but without printing the Expr. This probably isn't quite watertight, but it seems to work for now. Only check the body of the test function, since the argument list has a bogus Any hanging around.
|
Alas, as expected v0.5 has changed Expr enough that this is broken there. Needs more work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With julia-0.4.5, the recently added type inference tests fail due to a remaining Any which has not been optimized out. I started hacking around this and got a bit carried away. This change
BTW, what's the plan for 0.5 support at the moment? I did a Pkg.test("FixedSizeArrays") against it the other day and the upstream julialang churn seemed to have broken all sorts of things, so I haven't tried this patch against 0.5 yet. Am currently doing a new build to get up to date.My bad, I think this was just me getting confused about which FixedSizeArrays version I'm running.