[FIX] account_invoice_triple_discount: restore original discount field's precision by using change_digit function #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzamoabg
suggested changes
Aug 3, 2021
| @@ -84,7 +84,7 @@ def triple_discount_preprocess(self): | |||
| # more digits than allowed from field's precision, | |||
| # so let's increase it just for saving it correctly in cache | |||
| discount_field = self._fields['discount'] | |||
| discount_original_digits = discount_field._digits | |||
| discount_original_digits = dp.get_precision("Discount")(self.env.cr) | |||
There was a problem hiding this comment.
I think you can avoid this variable discount_original_digits... just assign dp.get_precision("Discount")(self.env.cr) in
…ion in order to avoid to have always (16, 10) as precision in case of any errors.
tafaRU
force-pushed
the
12.0-fix-account_invoice_triple_discount-subtotal_computation_digits
branch
from
475829f to
8aa2657
Compare
fredzamoabg
approved these changes
Aug 4, 2021
3 tasks
SimoRubi
requested changes
Sep 1, 2021
| @@ -100,7 +99,7 @@ def triple_discount_preprocess(self): | |||
| }) | |||
|
|
|||
| # Restore discount field's precision | |||
| discount_field._digits = discount_original_digits | |||
| discount_field._digits = dp.get_precision("Discount")(self.env.cr) | |||
There was a problem hiding this comment.
Here you are hardcoding 'Discount' precision for the field while previous code restored the original precision of the field.
How is this taking care of errors more than previous code?
|
@SimoRubi have you seen SimoRubi/sale-workflow#1 (comment) ? |
yes, but I don't think that changes the status of that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use change_digit function to restore original discount field's precision in order to avoid to have always (16, 10) as precision in case of any errors.