Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes issue #432: 🐛 Fixes right icon always shows default icon #437

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: Fixes issue #432: 🐛 Fixes right icon always shows default icon #437

merged 1 commit into from
Dec 30, 2024

Conversation

shubham-jitiya-simform
Copy link
Contributor

@shubham-jitiya-simform shubham-jitiya-simform commented Dec 30, 2024 •
edited
Loading

Description

  • Fixed right icon always shows default icon when providing custom icon in header style.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes issue: #432

@shubham-jitiya-simform shubham-jitiya-simform mentioned this pull request Dec 30, 2024
Closed
@shubham-jitiya-simform shubham-jitiya-simform marked this pull request as ready for review December 30, 2024 06:30
PRBaraiya
PRBaraiya approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit 077d35f into master Dec 30, 2024
1 check failed
@PRBaraiya
Copy link
Collaborator

Analysis issue will be solved with theme changes.

@PRBaraiya PRBaraiya deleted the fix/issue_432_icon_config branch December 30, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PRBaraiya PRBaraiya PRBaraiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham-jitiya-simform @PRBaraiya