Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ added start and end time to be display on timeline for day an… #356

Closed
wants to merge 1 commit into from

Conversation

apurva010
Copy link
Collaborator

@apurva010 apurva010 commented May 6, 2024

  • Added start and end time to be display on time line for day and week view.
  • Refer @jaiminrana05's code for start time to be display on timeline for day and week view. #280

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #267

@apurva010 apurva010 force-pushed the feature/paint_time_line_for_start_end_time branch 2 times, most recently from da19f60 to 4c759f1 Compare May 8, 2024 13:23
@apurva010 apurva010 force-pushed the feature/paint_time_line_for_start_end_time branch from 4c759f1 to cb6b9bd Compare May 10, 2024 05:48
@vatsaltanna-simformsolutions
Copy link
Collaborator

This PR doesn't display the timeline in the right spot when the timeline is in start hour, we will not merge this PR until we come up with a better solution.

@vatsaltanna-simformsolutions vatsaltanna-simformsolutions marked this pull request as draft May 10, 2024 06:13
@ParthBaraiya
Copy link
Collaborator

Will create the new PR once the changes are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paint TimeLine from 00:00
3 participants