Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AP mode support and error propagation improvements #87

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions drivers/wifi/siwx917/Kconfig.siwx917
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,37 @@ config WIFI_SIWX917_NET_STACK_OFFLOAD

endchoice

config WIFI_SIWX917_AP_MODE
bool "Enable AP Mode"
help
Enable this option to allow the device to operate in
Access Point (AP) mode instead of the default Station (STA) mode.

config WIFI_SIWX917_MAX_STATIONS
int "Maximum number of stations supported by AP"
range 1 8
default 4
depends on WIFI_SIWX917_AP_MODE
help
Sets the maximum number of stations that the
Access Point (AP) can support.

config WIFI_SIWX917_BEACON_INTERVAL
int "Beacon interval (in milliseconds)"
range 100 1000
default 100
depends on WIFI_SIWX917_AP_MODE
help
Defines the interval between beacon transmissions in AP mode.

config WIFI_SIWX917_DTIM_BEACON_COUNT
int "DTIM Beacon Count"
default 3
depends on WIFI_SIWX917_AP_MODE
help
Specifies the number of beacon intervals that must elapse
before the AP sends buffered multicast/broadcast traffic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An implementation of AP may provides tens of tuning options. Do we want to expose all of them in Kconfig? In addition, I feel it make sense (at least it does not consume more memory) to set these value during runtime.

So, maybe it is better to hardcode sane values and leave the opportunity to the user to patch the code if he really want to do something else?

I think it is not a blocker for now, because the number of options is limited. However, I would take care of the inflation of the number of options.


config NET_TCP_WORKQ_STACK_SIZE
default 2048

Expand Down
Loading
Loading