Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old journals fail to import due to missing 'ScanType' #16

Open
Silarn opened this issue Nov 18, 2024 · 0 comments
Open

Old journals fail to import due to missing 'ScanType' #16

Silarn opened this issue Nov 18, 2024 · 0 comments

Comments

@Silarn
Copy link
Owner

Silarn commented Nov 18, 2024

Until the Jan 25th 2018 update (v3, journal version 14) there was no ScanType in Scan events.

This is causing import errors for users with journals from back then.

There are a few caveats with this old data. Between the Aug 17th 2017 update (2.4b1) and the 3.0 update above, there was no way to differentiate between nav beacon scans and normal scans. Unfortunately that means those systems may have incorrect values in Pioneer as it will interpret them as scanned bodies. There's not much I can do about that.

However, the NavBeaconScan event was added in the Aug 24th 2017 update (2.4 open beta) which theoretically could be used to flag subsequent Scan events, but it seems problematic. I'd have to make sure I correctly track all the subsequent scans and then stop treating any additional scans as nav beacon data. I'm not sure how reliably that can be done.

I suppose the time period where this would have been an issue is relatively short, so maybe I'll just not worry about it.

I can differentiate between the 'basic' and 'detailed' scans by evaluating which data was included in the event.

Silarn referenced this issue in Silarn/EDMC-ExploData Nov 18, 2024
- 'ScanType' is missing in ~2017 era journals
- Add scan type parser to interpret old scan type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant