Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9 error "Broken Plugin" #14

Closed
hawkwynd opened this issue Nov 15, 2024 · 8 comments
Closed

2.9 error "Broken Plugin" #14

hawkwynd opened this issue Nov 15, 2024 · 8 comments

Comments

@hawkwynd
Copy link

Getting this error, checked to make sure I've extracted 2.9 correctly.

image

My plugins directory
image

The EDMC-BioScan directory
image

@Silarn
Copy link
Owner

Silarn commented Nov 15, 2024

You have the Windows version of ExploData installed? It's a hard dependency so it will probably crash if that's not loading.

The EDMC log would probably also help.

@Silarn
Copy link
Owner

Silarn commented Nov 15, 2024

I'm not sure if you had it installed prior to the update. I did update the bundled dependencies in ExploData. It's possible that simply overwriting them will cause issues so I would fully delete and reextract the latest Windows version just to rule it out.

@Silarn
Copy link
Owner

Silarn commented Nov 15, 2024

It's also possible that you are running into import errors if you neglected to update the latest ExploData. There were additional functions added in the newest version that BioScan expects to be there. If I just update the database structure then it'll usually import but the database version will be out of date.

I suppose I should also add import checks for ExploData so it won't just crash out.

@ak23550
Copy link

ak23550 commented Nov 17, 2024

I have the exact same issue. For me it is a first installation and i guess OP did a first install too. I'll explain my guess later first my system:
OpenSuSE Tumbleweed Linux / newest KDE Plasma
Running Linux/native version.
python311-SQLAlchemy version 2.0.36-1.1 installed
Screenshot_20241117_130121
Screenshot_20241117_130309
Screenshot_20241117_130358

Debug-Log-File for this one: Linux-1-EDMarketConnector-debug.log
Linux-1-EDMarketConnector-debug.log

I also tested the plugins in a virtual machine running windows 10 where i could reproduce exactly the errors as shown by hawkwynd by putting the plugins where they should be (exe version with SQLAlchemy included). (newest EDMC version downloaded a few minutes ago)
After reading this post i deleted the plugins and downloaded the next older versions 2.8.9 and 1.2.3. These plugin versions didn't show any errors at all. They also show up under settings --> plugins and there is a tab "BioScan" in settings. Also i noticed the explodata 1.2.3 has files in the "greenlet" folder and the 1.3 version does not.
Overwriting the old plugins with the newer resulted in explodata loading with no errors but bioscan being broken again.
Debug-Log-File for this one: Windows-1-EDMarketConnector-debug.log
Windows-1-EDMarketConnector-debug.log

Screenshot_20241117_130814
Screenshot is after first installation (newest versions of bioscan and explodata)

I have just tested the same procedure on my linux installation. Deleted the newest plugin versions and installed BioData 2.8.9 +Patch and Explodata 1.2.3 and it looks promising:
Screenshot_20241117_135529

but.... i now run into this:
Screenshot_20241117_141041
Debug-Log-File for this one: Linux-2-EDMarketConnector-debug.log
Linux-2-EDMarketConnector-debug.log

I hope i have included everything you need.

@ak23550
Copy link

ak23550 commented Nov 17, 2024

I just updated the plugins on my linux installation to the newest versions by overwriting the versions 1.2.3 and 2.8.9 and it now works as intended (i guess).
Screenshot_20241117_144742

So you can ignore the last part of my previous post. I will now try to get that overlay working on linux :-)

@Silarn
Copy link
Owner

Silarn commented Nov 18, 2024

The Linux overlay options are... limited. If you're using X.org still, it should work okay. You just have to compile the helper app it uses. The Wayland one is extremely finicky. I was able to get it to run on Fedora but it didn't really function as an overlay. It created a window which wasn't click-through and still had a titlebar. Good luck.

@Silarn
Copy link
Owner

Silarn commented Nov 18, 2024

The original issue was indeed due to an outdated ExploData. He confirmed this on Discord.

@ak23550 Your first Linux error is saying it can't find the load.py which means you installed the plugins incorrectly.

FileNotFoundError: [Errno 2] Datei oder Verzeichnis nicht gefunden: '/home/alex/.local/share/EDMarketConnector/plugins/BioScan/load.py'

The second Windows log is showing that ExploData was not the correct version. I checked the version (1.3.0) that was included with the BioScan release (2.9.0) and it is correct and has the files that were failing to load in your log:

ModuleNotFoundError: No module named 'ExploData.explo_data.edsm_parse

For the third one, this is indeed an issue I'll need to correct. You're the first person with very old logs that has bothered reporting this, I guess.

2024-11-17 13:10:14.037 UTC - ERROR - 55913:139833978652352:58111 <plugins>.ExploData.explo_data.<plugins>.ExploData.explo_data.<plugins>.ExploData.explo_data.<plugins>.ExploData.explo_data.<plugins>.ExploData.explo_data.<plugins>.ExploData.explo_data.journal_parse.JournalParse.parse_entry:132: Journal parse error:
b'{ "timestamp":"2017-10-16T17:31:01Z", "event":"Scan", "BodyName":"ICZ DQ-X b1-3", "DistanceFromArrivalLS":0.000000, "StarType":"M", "StellarMass":0.363281, "Radius":381030752.000000, "AbsoluteMagnitude":9.379684, "Age_MY":480, "SurfaceTemperature":2739.000000, "Luminosity":"Va", "RotationPeriod":179508.859375, "AxialTilt":0.000000 }\r\n'
Traceback (most recent call last):
  File "/home/alex/.local/share/EDMarketConnector/plugins/ExploData/explo_data/journal_parse.py", line 127, in parse_entry
    self.process_entry(entry)
  File "/home/alex/.local/share/EDMarketConnector/plugins/ExploData/explo_data/journal_parse.py", line 159, in process_entry
    self.add_star(entry)
  File "/home/alex/.local/share/EDMarketConnector/plugins/ExploData/explo_data/journal_parse.py", line 330, in add_star
    scan_type = get_scan_type(entry['ScanType'])
                              ~~~~~^^^^^^^^^^^^
KeyError: 'ScanType'

So I will have to deal with this. Apparently 'ScanType' wasn't a thing back then so I'll have to account for that in the importer. I'd suggest joining the Discord so I can provide a test version.

@Silarn
Copy link
Owner

Silarn commented Nov 18, 2024

Going to move the above issue to #16 and close this ticket. As far as I can tell load issues have all been install issues.

@Silarn Silarn closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants