Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend/executor): Add TERMINATED execution status #9185

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jan 3, 2025

Formerly known as FAILED with error message TERMINATED.

Changes 🏗️

  • Add TERMINATED to AgentExecutionStatus enum in DB schema (and its mirror in the front end)
  • Update executor to give terminated node and graph executions status TERMINATED instead of FAILED/COMPLETED
  • Add TERMINATED case to status checks referencing AgentExecutionStatus

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Start and forcefully stop a graph execution

@Pwuts Pwuts requested a review from a team as a code owner January 3, 2025 13:53
@Pwuts Pwuts requested review from Swiftyos and Bentlybro and removed request for a team January 3, 2025 13:53
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end platform/blocks labels Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit bfdaac9
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/677c5c0bd73967000880aafd

@github-actions github-actions bot added the size/m label Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit bfdaac9
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/677c5c0b3d1d730008f8aa90

@Pwuts Pwuts changed the title feat(backend/executor): Add "TERMINATED" execution status feat(backend/executor): Add TERMINATED execution status Jan 3, 2025
Formerly known as "FAILED" with error message "TERMINATED".
@Pwuts Pwuts force-pushed the pwuts/open-2285-implement-stopped-graph-execution-status branch from e3d6906 to 0df733d Compare January 3, 2025 14:01
@Pwuts Pwuts enabled auto-merge January 3, 2025 14:59
@Pwuts Pwuts requested review from majdyz and kcze and removed request for Bentlybro January 3, 2025 14:59
Copy link
Contributor

@majdyz majdyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Will this part of the code also capture the TERMINATED signal?
https://github.com/Significant-Gravitas/AutoGPT/pull/9185/files#diff-1b278ebf10a9da0fb5030010222b3a6df2b05a5463cad428cd6c38a1541b0f73R204-R220

If yes then it could be the terminated status is overridden? if not then it's all good :)

@Pwuts Pwuts added this pull request to the merge queue Jan 6, 2025
@majdyz majdyz removed this pull request from the merge queue due to a manual request Jan 6, 2025
@Pwuts
Copy link
Member Author

Pwuts commented Jan 6, 2025

Will this part of the code also capture the TERMINATED signal?
#9185 (files)

If yes then it could be the terminated status is overridden? if not then it's all good :)

I was having such an issue at first, which is why I did this:
8c80ed8

I tested it and now it works. :)

@Pwuts Pwuts added this pull request to the merge queue Jan 6, 2025
Merged via the queue into dev with commit c3caa11 Jan 6, 2025
22 checks passed
@Pwuts Pwuts deleted the pwuts/open-2285-implement-stopped-graph-execution-status branch January 6, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/blocks platform/frontend AutoGPT Platform - Front end size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants