Skip to content

Commit

Permalink
fix(backend): Fix webhook ingress URL generation (#9209)
Browse files Browse the repository at this point in the history
The enum's string *representation* was being inserted in the URL instead
of its string *value*.

Before:
`/api/integrations/ProviderName.GITHUB/webhooks/686db48c-e70d-4340-acf9-ccd0338fddc4/ingress`

After:
`/api/integrations/github/webhooks/686db48c-e70d-4340-acf9-ccd0338fddc4/ingress`

---------

Co-authored-by: Nicholas Tindle <[email protected]>
  • Loading branch information
Pwuts and ntindle authored Jan 6, 2025
1 parent c3caa11 commit 7a9a771
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion autogpt_platform/backend/backend/data/integrations.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class Webhook(BaseDbModel):
@computed_field
@property
def url(self) -> str:
return webhook_ingress_url(self.provider.value, self.id)
return webhook_ingress_url(self.provider, self.id)

@staticmethod
def from_db(webhook: IntegrationWebhook):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
from backend.integrations.providers import ProviderName
from backend.util.settings import Config

app_config = Config()


# TODO: add test to assert this matches the actual API route
def webhook_ingress_url(provider_name: str, webhook_id: str) -> str:
def webhook_ingress_url(provider_name: ProviderName, webhook_id: str) -> str:
return (
f"{app_config.platform_base_url}/api/integrations/{provider_name}"
f"/webhooks/{webhook_id}/ingress"
Expand Down

0 comments on commit 7a9a771

Please sign in to comment.