Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGN-7471 - connector logs support #31

Merged
merged 4 commits into from
Dec 12, 2024
Merged

SIGN-7471 - connector logs support #31

merged 4 commits into from
Dec 12, 2024

Conversation

volbobvol
Copy link
Collaborator

  • Added support for connector-side logs.
  • Log server response to the build log if we cannot deserialize it

core.error(log.message);
break;
default:
core.info(log.message);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhmm, should we maybe prefix this with unknown log level or something? IDK

core.warning(log.message);
break;
case LogLevelError:
core.error(log.message);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will logging to the error stream cause the workflow to actually fail? How does this interfere with the validation result?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will not. This has nothing to do with the validation result. It’s simply a way to convey additional information to the user—such as notifying them that, during validation, we noticed they have a policy file, so we will use it. Such a message is not part of the validation result; it’s just additional insight into what was happening in the connector.

@volbobvol volbobvol merged commit c7097b4 into main Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants