Implemented a better date conversion for 'date:' and 'modified:' fields. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2024 20:27
This PR fixes the following bad dates that were accepted previously: * date: 01-01-24 was accepted as 0001-01-24 * date: 24-01-24 was accepted as 0024-01-24 These will result in an error now. Recently in 300d61e the US-style dates were eliminated. Unfortunately, these are still very much used. I propose we continue supporting such dates, but we only accept unambiguous forms. Therefore, this commit implements and tests the dates of the following formats: * XXXX-XX-XX -- fully corresponds to yaml date format * XXXX/XX/XX, XXXX/XX/X, XXXX/X/XX, XXXX/X/X -- legacy, often occurs in (old) US-based sigmas
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bad dates that were accepted previously:
These will result in an error now.
Recently in 300d61e the US-style dates were eliminated. Unfortunately, these are still very much used. I propose we continue supporting such dates, but we only accept unambiguous forms.
Therefore, this commit implements and tests the dates of the following formats: