feat: build the button component based on updated spec #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadshaheer
changed the title
ahmadshaheer
changed the base branch from
main
to
fix/failing-package-generator
GeekBoySupreme
suggested changes
Mar 26, 2025
There was a problem hiding this comment.
- The border radius of the buttons do not adhere to the Figma. Needs to be fixed.
- There are no buttons with borders defined
- Add a variant for the pending state - where the icon of a button gets replaced with the loading spinner. Ideally I should be able to pass both
pendinganddisabledstates as props - Add hover states to the buttons according to the designs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/signoz/Buttons-190fcc6bcd198087a868ea762f915d01
https://www.figma.com/design/egMidgk6VJDXTumxcCYUl1/Periscope---Primitives?node-id=12-739&t=vmKSmLVeFlTWrGDr-1