Color implementation #106
Open
Color implementation #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Come to think of it, this macro would allow removal of the |
|
Sorry I didn't get to this this weekend. I'll try to look at it soon. |
|
Think this is ready for discussion now (though no rush). Happy to take feedback: I want to make it work for what you want and need for the project. |
|
Note that a couple of types are unfinished: these need finishing (if I can work out what they do) or removing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (currently partial) implementation of some of the color types. More are planned to follow.
The main reason for starting a partial PR is to ask if the changes to the internal API are reasonable: the removal of the
new_plot_n()functions and effective replacement with agenerate_datamacro.(Also this has snowballed a bit and led me to try implementing several new plot types as I started trying to reproduce some of the gnuplot demos as my examples - those should probably come as separate PRs at some point)
Addresses #105 #86