Add support for v2 host announcements #1669
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/v2-host-announcements
branch
from
d6f7b67
to
3f770fe
Compare
ChrisSchinnerl
force-pushed
the
chris/v2-host-announcements
branch
from
72512df
to
25f30ba
Compare
ChrisSchinnerl
force-pushed
the
chris/v2-host-announcements
branch
from
0c04587
to
f9f2bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
host_announcementstable to ahost_addressestable which holds all the announced addresses of a host including the protocol they were announced for. It also adds a new field to theHosttype which contains the announcedv2addresses.Since things are now getting a lot more complex since hosts can announce multiple IP addresses as well as domain names, we only consider the first 5 announced addresses per protocol. Regardless of whether they are IP addresses or domains.
The redundant IP check will still enforce the same rules. e.g. announcing 3 domains and 2 IPs is fine as long as after resolving the domains, the host only ends up with at most 2 IPs where one is IPv4 and the other is IPv6.
For the sake of simplicity and because I'd like to avoid this going out of hand I also removed the persisted addresses. We still cache resolved addresses in our dialer, but we don't consider unresolvable hosts redundant anymore. Instead we keep them until the scanner causes the to drop out of the set.
Closes #1668