Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHP4 #200

Merged
merged 74 commits into from
Oct 28, 2024
Merged

RHP4 #200

merged 74 commits into from
Oct 28, 2024

Conversation

n8maninger
Copy link
Member

No description provided.

@n8maninger n8maninger marked this pull request as draft September 13, 2024 03:18
@n8maninger n8maninger mentioned this pull request Sep 13, 2024
Merged
@n8maninger n8maninger force-pushed the nate/rhp4 branch 2 times, most recently from bd029b2 to f240139 Compare September 14, 2024 00:03
lukechampine and others added 23 commits September 17, 2024 09:58
@lukechampine @n8maninger
rhp/v4: Add package
4b8b5fb
@lukechampine @n8maninger
rhp/v4: Split RPCs into distinct types
4aff767
@lukechampine @n8maninger
rhp/v4: Further tweaks
f87b97b
@lukechampine @n8maninger
rhp/v4: Remove RPC wrapping types
84b8197
@lukechampine @n8maninger
rhp/v4: Split WriteRequest apart again
c50e95e
@lukechampine @n8maninger
rhp/v4: Remove Transport and Stream
5345902
@lukechampine @n8maninger
rhp/v4: Export Request.ID
89bd171
@lukechampine @n8maninger
rhp/v4: Add AccountIDs
507e3a3
@lukechampine @n8maninger
rhp/v4: Send SatisfiedPolicies
2572aad
@lukechampine @n8maninger
rhp/v4: Add Proof to RPCSectorRootsResponse
1b40f96
@lukechampine @n8maninger
rhp/v4: Make Account a PublicKey
f23104c
@lukechampine @n8maninger
types: Remove V2FileContract.TotalCollateral
c043522
@lukechampine @n8maninger
types: Rename MissedHostValue -> HostCollateral
0cf54ec
@n8maninger
switch net.Conn with reader and writer
8ca5519
@lukechampine @n8maninger
rhp/v4: Add various RPC helpers
0f48aed
@n8maninger
rhp/v4: add json tags
e1a00b7
@n8maninger
rhp4: implement initial rhp4 spec
981f67e
@n8maninger
types: remove debug policy test
e41015d
@n8maninger
rhp4: remove HostSettings.Sign()
024e87b
@n8maninger
rhp: remove update todo
5a1fb00
@n8maninger
rhp4: minimize form and renew contract RPC
6f671cd
@n8maninger
rhp4: fix lint
a9e3f56
@n8maninger
rhp4: add common request validation methods
057286a
@n8maninger n8maninger mentioned this pull request Oct 22, 2024
Draft
peterjan
peterjan reviewed Oct 25, 2024
View reviewed changes
rhp/v4/rhp.go Outdated Show resolved Hide resolved
peterjan
peterjan reviewed Oct 25, 2024
View reviewed changes
rhp/v4/validation.go Outdated Show resolved Hide resolved
peterjan
peterjan reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ChrisSchinnerl
ChrisSchinnerl reviewed Oct 25, 2024
View reviewed changes
consensus/validation_test.go Outdated Show resolved Hide resolved
rhp/v4/merkle.go Show resolved Hide resolved
rhp/v4/rhp.go Show resolved Hide resolved
rhp/v4/rhp.go Show resolved Hide resolved
@n8maninger n8maninger merged commit 8319d41 into master Oct 28, 2024
9 checks passed
@n8maninger n8maninger deleted the nate/rhp4 branch October 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

@lukechampine lukechampine Awaiting requested review from lukechampine

@peterjan peterjan Awaiting requested review from peterjan

Assignees

@lukechampine lukechampine

@n8maninger n8maninger

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n8maninger @peterjan @lukechampine @ChrisSchinnerl