Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update run_benchmarks.rb to pass the JSON to render_graph #342

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Update run_benchmarks.rb to pass the JSON to render_graph #342

merged 2 commits into from
Oct 7, 2024

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Oct 7, 2024

Sorry for the many small PRs, just realized this needs to be updated as well.

@maximecb
Copy link
Contributor

maximecb commented Oct 7, 2024

Since lots of small things need to be updated

Do you think you could add an automated test?
Quickly run one benchmark to produce data and then try to run this script?

@eregon
Copy link
Contributor Author

eregon commented Oct 7, 2024

Added, let's see if it works there.
It might not because e.g. --graph needs ImageMagick to be installed.

@eregon
Copy link
Contributor Author

eregon commented Oct 7, 2024

The test works now

@maximecb maximecb merged commit fb25c3c into Shopify:main Oct 7, 2024
4 checks passed
@eregon eregon deleted the patch-3 branch October 7, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eregon @maximecb