Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert misc/graph.rb to take JSON as input instead of CSV #338

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Oct 6, 2024

  • JSON is much easier to merge than CSV, so this makes it possible to graph from multiple results files. (jq '. * input' can be used to merge JSON files)
  • The JSON is also more cleanly structured.
  • If the input is a file ending in .csv automatically use the neighbor .json file for compatibility.

* JSON is much easier to merge than CSV, so this makes
  it possible to graph from multiple results files.
  (`jq '. * input'` can be used to merge JSON files)
* The JSON is also more cleanly structured.
* If the input is a file ending in .csv automatically use
  the neighbor .json file for compatibility.
misc/graph.rb Outdated Show resolved Hide resolved
Co-authored-by: Takashi Kokubun <[email protected]>
@maximecb maximecb merged commit c1560fa into Shopify:main Oct 7, 2024
4 checks passed
@eregon eregon deleted the graph-json branch October 7, 2024 18:11
@eregon eregon mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants