Check that the ruby configuration isn't changed during the benchmark #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwstauner
force-pushed
the
rwstauner/check-ruby-config
branch
from
e57f09c to
e55511c
Compare
rwstauner
commented
Sep 12, 2024
k0kubun
reviewed
Sep 12, 2024
rwstauner
force-pushed
the
rwstauner/check-ruby-config
branch
from
e55511c to
d16c837
Compare
eregon
reviewed
Sep 12, 2024
rwstauner
force-pushed
the
rwstauner/check-ruby-config
branch
from
d16c837 to
e93dccc
Compare
rwstauner
force-pushed
the
rwstauner/check-ruby-config
branch
from
e93dccc to
c75deec
Compare
|
Another option would be to make a new harness that we use in CI that just wraps the regular harness and adds this logic if you think that'd be better. |
k0kubun
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have prevented the bug fixed by #328