Regenerate protoboeuf benchmark #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximecb
reviewed
May 2, 2024
benchmarks/protoboeuf/benchmark.rb
Outdated
| @@ -7,5 +7,5 @@ | |||
| fake_msg_bins = Marshal.load(File.binread('encoded_msgs.bin')) | |||
|
|
|||
| run_benchmark(20) do | |||
| fake_msg_bins.each { |bin| ProtoBoeuf::ParkingLot.decode bin } | |||
| fake_msg_bins.each { |bin| Upstream::ParkingLot.decode bin } | |||
There was a problem hiding this comment.
You can't use upstream here? You'd be benchmarking Google's protobuf?
There was a problem hiding this comment.
Ah, this is pretty confusing. The name is actually from package upstream; in the .proto file and in the protoboeuf repo it's generating with a namespace override:
https://github.com/Shopify/protoboeuf/blob/9c97773fa74a544aff1b6c83a7acc4834987d7e5/Rakefile#L58-L62
It's just the name, though. Nothing loads google-protobuf in this benchmark. Anyways, fixed.
There was a problem hiding this comment.
Ok. Maybe we should remove package upstream; from the .proto file.
There has been a bunch of generator changes since the benchmark was added. Generated using Shopify/protoboeuf@9c97773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a bunch of generator changes since the benchmark was
added.
Generated using Shopify/protoboeuf@9c97773