Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused listen gem from Rails benchmarks #282

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

p8
Copy link
Contributor

@p8 p8 commented Feb 5, 2024

The listen gem is no longer added to the default Gemfile of new Rails app: rails/rails#42985
It is not used in the benchmarks either, as no file_watcher is configured in any app.
This also removes the ffi gem which can take some time to build.

The `listen` gem is no longer added to the default Gemfile of new Rails
app: rails/rails#42985
It is not used either as no `file_watcher` is configured in any app.
@p8
Copy link
Contributor Author

p8 commented Feb 5, 2024

I have signed the CLA!

Copy link
Member

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maximecb maximecb merged commit b13e39c into Shopify:main Feb 6, 2024
4 checks passed
@p8 p8 deleted the remove-some-rails-dependencies branch February 6, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants