Add --bench and --warmup flags #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
reviewed
Jan 8, 2024
eregon
approved these changes
Jan 8, 2024
Co-authored-by: Benoit Daloze <[email protected]>
|
I've thought about this too. How about a |
maximecb
approved these changes
Jan 8, 2024
How about calling it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often use
WARMUP_ITRS=2 MIN_BENCH_ITRS=3 MIN_BENCH_TIME=0for quick speedup check. But it's hard to remember and I always use my shell history to pull it up.This PR proposes to allow specifying it with
--warmup=2 --bench=3.