Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoom depends on RBI #629

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Spoom depends on RBI #629

merged 1 commit into from
Jan 21, 2025

Conversation

rzane
Copy link
Contributor

@rzane rzane commented Jan 16, 2025

This gem depends on rbi (here), but rbi does not appear in the gemspec.

$ mkdir spoom-test
$ cd spoom-test
$ bundle init    
$ bundle add spoom
$ bundle exec ruby -r spoom -e 'puts "OK"'
<internal:/Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require': cannot load such file -- rbi (LoadError)
	from <internal:/Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from /Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/spoom-1.5.1/lib/spoom/sorbet/sigs.rb:4:in `<top (required)>'
	from <internal:/Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from <internal:/Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from /Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/spoom-1.5.1/lib/spoom/cli/srb/sigs.rb:4:in `<top (required)>'
	from /Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/spoom-1.5.1/lib/spoom/cli/srb.rb:7:in `require_relative'
	from /Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/spoom-1.5.1/lib/spoom/cli/srb.rb:7:in `<top (required)>'
	from /Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/spoom-1.5.1/lib/spoom/cli.rb:8:in `require_relative'
	from /Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/spoom-1.5.1/lib/spoom/cli.rb:8:in `<top (required)>'
	from <internal:/Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from <internal:/Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from /Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/spoom-1.5.1/lib/spoom.rb:22:in `<top (required)>'
	from <internal:/Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from <internal:/Users/rayzane/.rbenv/versions/3.2.3/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'

@rzane rzane requested a review from a team as a code owner January 16, 2025 17:55
Copy link
Collaborator

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! You'll have to run bundle to update the Gemfile.lock. Thanks.

@rzane
Copy link
Contributor Author

rzane commented Jan 21, 2025

Thanks, @Morriar. Should be good to go now.

Copy link
Collaborator

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Morriar Morriar merged commit 8b8f31e into Shopify:main Jan 21, 2025
5 checks passed
@Morriar Morriar added the bugfix Fix a bug label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants