Add sliceLocation helper to simplify location operations
#406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
reviewed
Feb 6, 2025
| @@ -2,9 +2,9 @@ name: CI | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [prism] | |||
| branches: [prism, prism-squashed] | |||
Comment on lines
+1935
to
+1938
| std::string_view Translator::sliceLocation(pm_location_t loc) { | ||
| return std::string_view(reinterpret_cast<const char *>(loc.start), loc.end - loc.start); | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't have a super strong opinion -- what do you think about moving this to Parser.cc? It only relies on Prism's parse tree state and could feasibly be useful even when we're no longer translating.
There was a problem hiding this comment.
Given that Parser current doesn't have any other helper functions and we're still many PRs away from addressing all the feedback, I think it'd be simpler for future changes if we keep this and future helpers in the Translator by default, until we have a clearer understanding on how they'd be used outside of the translator.
egiurleo
approved these changes
Feb 10, 2025
st0012
added a commit
that referenced
this pull request
Feb 18, 2025
* Add sliceLocation helper to simplify location operations * Run CI on prism-squahed too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As suggested in sorbet#8485 (comment) and sorbet#8485 (comment)
Test plan
See included automated tests.