Avoid translating implicit rest nodes in parameters

Shopify · Feb 12, 2025 · 5db265d · 5db265d
1 parent a06ff97
commit 5db265d
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/parser/prism/Translator.cc b/parser/prism/Translator.cc
@@ -1037,8 +1037,11 @@ unique_ptr<parser::Node> Translator::translate(pm_node_t *node) {
             translateMultiInto(params, requireds);
             translateMultiInto(params, optionals);
 
-            if (paramsNode->rest != nullptr)
-                params.emplace_back(translate(paramsNode->rest));
+            auto prismRestNode = paramsNode->rest;
+            // Implicit rest node in parameters don't need to be translated
+            if (prismRestNode != nullptr && !PM_NODE_TYPE_P(prismRestNode, PM_IMPLICIT_REST_NODE)) {
+                params.emplace_back(translate(prismRestNode));
+            }
 
             translateMultiInto(params, posts);
             translateMultiInto(params, keywords);

diff --git a/test/prism_regression/call_block_param.parse-tree.exp b/test/prism_regression/call_block_param.parse-tree.exp
@@ -198,6 +198,25 @@ Begin {
       }
       body = NULL
     }
+    Block {
+      send = Send {
+        receiver = NULL
+        method = <U foo>
+        args = [
+        ]
+      }
+      args = Args {
+        args = [
+          Arg {
+            name = <U bar>
+          }
+          Arg {
+            name = <U baz>
+          }
+        ]
+      }
+      body = NULL
+    }
     Send {
       receiver = NULL
       method = <U foo>

diff --git a/test/prism_regression/call_block_param.rb b/test/prism_regression/call_block_param.rb
@@ -30,6 +30,8 @@
 
 foo { |bar; baz, qux| }
 
+foo { |bar, baz,| }
+
 foo(&forwarded_block)
 
 foo&.bar {}