Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GraphQL autocomplete for Javascript #923

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented Jan 8, 2025

WHY are these changes introduced?

Enables GraphQL autocompletion of queries and mutations in Javascript projects.

screencast.2025-01-08.09-54-30.mp4

WHAT is this pull request doing?

This changes the config to use an ES6 export instead of a cjs export in the .graphqlrc.xs file.
The previous export was causing an error with the GraphQL Vscode extension, to break the autocomplete.

image

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-remix#liz/js-graphql-autocomplete

Checklist

  • I have made changes to the README.md file and other related documentation, if applicable
  • I have added an entry to CHANGELOG.md
  • I'm aware I need to create a new release when this PR is merged

@lizkenyon lizkenyon requested a review from a team as a code owner January 8, 2025 16:07
The cjs export was causing errors with the vscode extension
@lizkenyon lizkenyon force-pushed the liz/js-graphql-autocomplete branch from 2504069 to 6b89dd0 Compare January 8, 2025 16:09
Copy link
Contributor

@sle-c sle-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's really interesting

@lizkenyon lizkenyon merged commit 149ff4f into main Jan 8, 2025
5 checks passed
@lizkenyon lizkenyon deleted the liz/js-graphql-autocomplete branch January 8, 2025 18:58
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
Enable GraphQL autocomplete for Javascript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants