-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overhaul to use vite + vitest over webpack 🎉 #718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
https: //shopify.dev/apps/store/security/iframe-protection Co-Authored-By: Paulo Margarido <[email protected]>
shopify cli will override this file as necessary, or you can run shopify app connect and it will connect to your partner org Co-Authored-By: Paulo Margarido <[email protected]>
true SSR can come at a later date! Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
the docs/architecture explainer will be on shopify.dev and we will introduce a proper changelog Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]>
Co-Authored-By: Paulo Margarido <[email protected]> Co-Authored-By: Finn Tessier-Lavigne <[email protected]>
JaKXz
commented
Mar 4, 2022
and other minor tweaks/cleanup
and remove unused deps and generate command
JaKXz
commented
Mar 4, 2022
JaKXz
commented
Mar 4, 2022
eliasrumley
reviewed
Mar 4, 2022
Co-authored-by: Elias Rumley <[email protected]>
paulomarg
approved these changes
Mar 7, 2022
eliasrumley
approved these changes
Mar 7, 2022
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 Depends on
https://github.com/Shopify/shopify-dev/pull/15558
Releasing Shopify/shopify-api-js#316