Return 403 in non-embedded XHR requests #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteodepalo
approved these changes
Feb 12, 2024
paulomarg
force-pushed
the
return_403_for_xhr_requests
branch
from
2b80081 to
d2c6674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes #470
As pointed out in the issue, we're returning a 302 that runs into CORS errors, making the
validateAuthenticatedSessionmiddleware essentially broken for non-embedded apps.WHAT is this pull request doing?
Returning the same 403 response headers we return for XHR requests for embedded apps. It'll be up to the app to catch and handle those requests, but it'll be a valid response, instead of a 302 that will always fail.
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)