Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add check function to billing API #634

Merged
merged 6 commits into from
Feb 8, 2024
Merged

[Feature] Add check function to billing API #634

merged 6 commits into from
Feb 8, 2024

Conversation

lizkenyon
Copy link
Contributor

WHY are these changes introduced?

Fixes How to handle a free tier with the billing API?

WHAT is this pull request doing?

  • This PR exposes the check function from the API layer on the billing API
  • Developers want an easy way to determine what plans a merchant has active without throwing an error.
  • This will allow developers to implement a free tier for their app plan.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@lizkenyon
Add check to the billing API
afa7e2d 
Devs are requesting a way to see what billing plans are active w/o throwing an error

This will be useful for devs with a free option billing plan

Fix tests
@lizkenyon
build docs
da75c00
@lizkenyon
changelog
6d5b4e0
@lizkenyon lizkenyon requested a review from a team as a code owner February 6, 2024 18:07
paulomarg
paulomarg approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, but this is 🔥

packages/shopify-app-remix/src/server/authenticate/admin/billing/__tests__/check.test.ts Outdated Show resolved Hide resolved
packages/shopify-app-remix/src/server/authenticate/admin/billing/types.ts Outdated Show resolved Hide resolved
packages/shopify-app-remix/src/server/authenticate/admin/billing/types.ts Outdated Show resolved Hide resolved
@lizkenyon lizkenyon mentioned this pull request Feb 8, 2024
Closed
@lizkenyon lizkenyon merged commit 28db9a8 into main Feb 8, 2024
10 checks passed
@lizkenyon lizkenyon deleted the liz/check-billing branch February 8, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to handle a free tier with the billing API?
2 participants
@lizkenyon @paulomarg