Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token exchange docs #602

Merged
merged 19 commits into from
Jan 31, 2024
Merged

Token exchange docs #602

merged 19 commits into from
Jan 31, 2024

Conversation

zzooeeyy
Copy link
Contributor

@zzooeeyy zzooeeyy commented Jan 25, 2024

WHY are these changes introduced?

Add guides and references for token exchange

WHAT is this pull request doing?

"OAuth route" section

Before

image

After

image

New section for "new embedded authorization strategy"

image

Future flags in shopifyApp

Before

image

After

image

Future flags section

Before

image

After

image

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@zzooeeyy zzooeeyy force-pushed the token-exchange-docs branch 11 times, most recently from aa3862f to 4e921f7 Compare January 26, 2024 19:58
@zzooeeyy zzooeeyy force-pushed the token-exchange-docs branch from 9959548 to 9761c68 Compare January 26, 2024 20:16
@zzooeeyy zzooeeyy force-pushed the token-exchange-docs branch from 9761c68 to d53215f Compare January 26, 2024 20:18
@zzooeeyy zzooeeyy marked this pull request as ready for review January 26, 2024 21:17
@zzooeeyy zzooeeyy requested a review from a team as a code owner January 26, 2024 21:17
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Other than the changeset stuff this works for me.

packages/shopify-app-remix/.changeset/README.md Outdated Show resolved Hide resolved
packages/shopify-app-remix/.changeset/new-baboons-tap.md Outdated Show resolved Hide resolved
@@ -20,6 +20,7 @@ const data: ReferenceEntityTemplateSchema = {
'Set future flags using the `future` configuration field to opt in to upcoming breaking changes.' +
'\n\nWith this feature, you can prepare for major releases ahead of time, as well as try out new features before they are released.',
type: 'FutureFlags',
filePath: 'src/server/future/flags.ts',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@rezaansyed rezaansyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but looks great overall!

@abalejr abalejr merged commit 59b1cb3 into main Jan 31, 2024
10 checks passed
@abalejr abalejr deleted the token-exchange-docs branch January 31, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants