-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token exchange docs #602
Token exchange docs #602
Conversation
aa3862f
to
4e921f7
Compare
9959548
to
9761c68
Compare
9761c68
to
d53215f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Other than the changeset stuff this works for me.
@@ -20,6 +20,7 @@ const data: ReferenceEntityTemplateSchema = { | |||
'Set future flags using the `future` configuration field to opt in to upcoming breaking changes.' + | |||
'\n\nWith this feature, you can prepare for major releases ahead of time, as well as try out new features before they are released.', | |||
type: 'FutureFlags', | |||
filePath: 'src/server/future/flags.ts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments but looks great overall!
WHY are these changes introduced?
Add guides and references for token exchange
WHAT is this pull request doing?
"OAuth route" section
Before
After
New section for "new embedded authorization strategy"
Future flags in shopifyApp
Before
After
Future flags section
Before
After
Type of change
Checklist
yarn changeset
to create a draft changelog entry (do NOT update theCHANGELOG.md
files manually)