Fix dev dependencies across all projects #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
fix_dev_dependencies
branch
from
fa1ef12 to
b4eeb24
Compare
lizkenyon
approved these changes
Jan 24, 2024
| "eslint": "^8.55.0", | ||
| "eslint-plugin-prettier": "^4.2.1", | ||
| "jest": "^29.1.0", |
There was a problem hiding this comment.
Looks like we were at "@types/jest": "^29.5.1", in shopify-app-remix. Though not that, that should cause us any problems
There was a problem hiding this comment.
The ^ should align them on the latest non-breaking change, so I think we're ok!
There were no errors so I'm assuming it was happy, since this is only a dev dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently, there's a lot of repetition on our dependencies across the multiple packages in this repo, which makes it way harder to maintain them than it has to be. The vast majority of the problematic dependencies are development only so they shouldn't have any effect on production.
WHAT is this pull request doing?
Removing any dependencies from the individual packages that were already added at the top level.
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)