Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace query() call with request() #592

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

paulomarg
Copy link
Contributor

WHY are these changes introduced?

Closes #586

The express package was still calling client.query() from the GrahpQL client in one place, which should be a call to .request().

WHAT is this pull request doing?

Fixing the call.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change

@paulomarg paulomarg requested a review from a team as a code owner January 24, 2024 15:41
@paulomarg paulomarg merged commit a866d7c into main Jan 24, 2024
10 checks passed
@paulomarg paulomarg deleted the fix_express_client_calls branch January 24, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shopify-app-express] Warning: The query method is deprecated, and was replaced with the request method
2 participants