Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull changes from main #568

Closed
wants to merge 30 commits into from
Closed

Pull changes from main #568

wants to merge 30 commits into from

Conversation

zzooeeyy
Copy link
Contributor

WHY are these changes introduced?

main branch has changed a lot since we last pulled, shopify-api-js has been updated to 9.0.0 on main.

WHAT is this pull request doing?

I ran

git checkout main
git pull
git checkout feature/token-exchange
git pull
git checkout -b pull-changes-from-main
git merge main

rachel-carvalho and others added 30 commits December 7, 2023 11:33
@rachel-carvalho @rezaansyed
add unstable_newEmbeddedAuthStrateg future flag
f00205b
@rachel-carvalho @rezaansyed
add token exchange strategy
7f2737c
@rezaansyed
Enable token exchange strategy when future flag is enabled
8df3491
@rachel-carvalho @rezaansyed
setup auth code flow tests with future flag off
a69e426
@rachel-carvalho @rezaansyed
add tests to token exchange strategy
f0a8362
@rachel-carvalho @rezaansyed
move tests that redirect when no session is found into auth code flow…
b366dda 
… test folder

move embedded search param check to generic doc request tests
@rezaansyed
throw 500 for most token exchange errors and complete code coverage
7a562f1
@rezaansyed
Fix logging
ed4b46e
@rezaansyed
Update types to account for unstable_tokenExchange and unstable_newEm…
ba932e4 
…beddedAuthStrategy future flags
@rezaansyed
Add changeset
7980ab5
@rezaansyed
Update future flag description
2811004
@rezaansyed
Log throttling errors on webhook registration
ceebd32
@rezaansyed
Refactor to address review comments
711b6d3
@rezaansyed
Introduce idempotent promise handler
942ed9b
@rezaansyed
Merge pull request #522 from Shopify/idempotent-promise-handler
d777a9d 
Idempotent promise handler
@zzooeeyy
Redirect to install from app home page if future flag is on and app i…
27f3be8 
…s embedded
@rachel-carvalho @rezaansyed
move invalid access token redirect to auth tests to auth code flow st…
5b3d8fd 
…rategy
@rachel-carvalho
Merge remote-tracking branch 'origin/feature/token-exchange' into exp…
470890b 
…erimental
@rachel-carvalho @rezaansyed
delegate handling invalid access token errors to auth strategy
c679502
@rezaansyed
Add error handling for token exchange strategy on invalid API requests
34e1752
@zzooeeyy
Redirect to new admin URL instead of legacy
c09d26e
@rachel-carvalho
Merge pull request #527 from Shopify/zoey/redirect-to-install
92968c8 
Remix: Redirect to admin install path if future flag is enabled
@rezaansyed
Clear stale identifiers in IdempotentPromiseHandler
c607e00
@rezaansyed
Merge pull request #528 from Shopify/idempotent-handler-clear-identif…
f7cab50 
…iers

Clear stale identifiers in IdempotentPromiseHandler
@rezaansyed
Move SessionContext to authenticate as it is only used there
746e7aa
@rezaansyed
Inject error handling strategy on after auth API calls
158ef77
@rezaansyed
Pass in handleClientError method from the strategy
3fc0466
@rezaansyed
Merge pull request #532 from Shopify/add-handle-client-error-token-ex…
d2a7613 
…change

Handle error cases for embedded apps using token exchange strategy
@zzooeeyy
Merge changes from main and fix conflicts
d5d2b5b
@zzooeeyy
Fix token-exchange/admin-client test
fac204d
@rezaansyed rezaansyed force-pushed the feature/token-exchange branch 2 times, most recently from c4fb5fb to 4683a0e Compare January 17, 2024 18:26
Base automatically changed from feature/token-exchange to main January 17, 2024 19:05
@zzooeeyy zzooeeyy closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzooeeyy @rachel-carvalho @rezaansyed