Increase default body parser size #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
lizkenyon
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Hey @tschoffelen
We would like to get this merged! Could you add a changeset for this!
lizkenyon
approved these changes
Jan 15, 2024
|
Is this one ready to get merged @lizkenyon, or is there anything more I need to do? |
|
Sorry I missed your ping @tschoffelen Merging now. Thank you for your contribution! It is highly appreciated 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
An issue I come across occasionally is a webhook payload that is rejected due to a "HTTP:413 Request Entity Too Large" error. This is due to the
body-parserlimit by default being set to100kb.WHAT is this pull request doing?
This PR introduces a new default value for this, which should alleviate this issue.
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)Notes
I'm unsure if any tests need to be added for this change - please do let me know if you have an idea of how you'd like to see this tested.