Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify remix README file #458

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Simplify remix README file #458

merged 1 commit into from
Oct 5, 2023

Conversation

paulomarg
Copy link
Contributor

@paulomarg paulomarg commented Oct 3, 2023

WHY are these changes introduced?

Now that we have documentation for the Remix package in shopify.dev, we shouldn't duplicate some of the content in the package README.

WHAT is this pull request doing?

Changing the README to cover setting up the app / package with simpler examples, but linking out to the docs where relevant.

See https://github.com/Shopify/shopify-app-js/blob/simplify_remix_readme/packages/shopify-app-remix/README.md

@paulomarg paulomarg requested a review from a team as a code owner October 3, 2023 19:16
@paulomarg paulomarg force-pushed the simplify_remix_readme branch 2 times, most recently from 3bf60ef to c1045b9 Compare October 3, 2023 19:24
Copy link
Contributor

@byrichardpowell byrichardpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@paulomarg paulomarg force-pushed the simplify_remix_readme branch from c1045b9 to 47c4a02 Compare October 5, 2023 19:03
@paulomarg paulomarg merged commit 52bd611 into main Oct 5, 2023
11 checks passed
@paulomarg paulomarg deleted the simplify_remix_readme branch October 5, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants