Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate flow #446

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Authenticate flow #446

merged 4 commits into from
Feb 8, 2024

Conversation

byrichardpowell
Copy link
Contributor

@byrichardpowell byrichardpowell commented Sep 15, 2023

WHY are these changes introduced?

With the changes in Shopify/shopify-api-js#987, we'll be able to properly authenticate Flow extension requests in apps. We need to provide a public API for that kind of authentication in the Remix package.

WHAT is this pull request doing?

Adding a new shopify.authenticate.flow(request) call that will perform the necessary checks and return the payload / API clients.

Type of change

  • Minor: New feature (non-breaking change which adds functionality)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@byrichardpowell byrichardpowell requested a review from a team as a code owner September 15, 2023 20:07
@paulomarg paulomarg self-assigned this Jan 30, 2024
@paulomarg paulomarg force-pushed the authenticate-flow branch 3 times, most recently from fa5d866 to 3fdae8e Compare February 5, 2024 17:15
@paulomarg paulomarg changed the base branch from main to update_shopify_api February 7, 2024 19:19
@paulomarg paulomarg changed the title [WIP] Authenticate flow Authenticate flow Feb 7, 2024
Base automatically changed from update_shopify_api to main February 7, 2024 19:37
Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test this and seems to be working as intended! 💯

image

@paulomarg paulomarg merged commit 689d338 into main Feb 8, 2024
10 checks passed
@paulomarg paulomarg deleted the authenticate-flow branch February 8, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants