Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add DynamoDB table schema #426

Merged
merged 10 commits into from
Dec 13, 2023
Merged

[Docs] Add DynamoDB table schema #426

merged 10 commits into from
Dec 13, 2023

Conversation

joelvh
Copy link
Contributor

@joelvh joelvh commented Aug 31, 2023

WHY are these changes introduced?

Fixes #386

It's unclear what the DynamoDB table schema should be.

WHAT is this pull request doing?

This updates the docs with an example schema. (This is based on the test suite.)

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@joelvh joelvh requested a review from a team as a code owner August 31, 2023 21:22
@joelvh
Copy link
Contributor Author

joelvh commented Aug 31, 2023

I have signed the CLA!

Copy link
Contributor

@lizkenyon lizkenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these docs updates!

We look forward to your next contribution!

@lizkenyon
Copy link
Contributor

@joelvh Could you add an empty changelog yarn changeset --empty as well run prettier on the markdown file to get the pipline to pass! :)

@joelvh
Copy link
Contributor Author

joelvh commented Dec 7, 2023

@lizkenyon no problem - added!

@lizkenyon
Copy link
Contributor

Hi @joelvh

The pipeline is failing because of formatting. Running yarn prettier --write packages/shopify-app-session-storage-dynamodb/README.md should resolve this.

@joelvh
Copy link
Contributor Author

joelvh commented Dec 8, 2023

@lizkenyon done!

@lizkenyon lizkenyon merged commit 1f5c24a into Shopify:main Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB Session Storage Handler - Resource Not Found or Key unsupported by Schema
2 participants