Add Headers to GraphQL client response #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
approved these changes
Jul 15, 2024
| export type GraphQLResponse< | ||
| Operation extends keyof Operations, | ||
| Operations extends AllOperations, | ||
| > = ResponseWithType<FetchResponseBody<ReturnData<Operation, Operations>>>; | ||
| > = ResponseWithType<FetchResponse<ReturnData<Operation, Operations>>>; |
There was a problem hiding this comment.
Will this return headers as an object or as a Headers type? In the remix package, we're returning a proper Response object, so the headers should be the fetch API ones too.
lizkenyon
force-pushed
the
liz/add-header-graphql-client-response
branch
from
16c79ed to
a4fe44c
Compare
lizkenyon
force-pushed
the
liz/add-header-graphql-client-response
branch
from
a4fe44c to
7e7b1e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #637
When we migrated to the new clients we no longer returned the headers for successful responses.
Even if a request is successful developers may need to access the headers for debugging.
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)