Merge pull request #660 from Shopify/liz/update-app-config-type

Update AppConfig type to readonly
Shopify · Feb 23, 2024 · fb1317f · fb1317f
2 parents 835dd9f + 9c626d2
commit fb1317f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/mighty-bikes-sneeze.md b/.changeset/mighty-bikes-sneeze.md
@@ -0,0 +1,6 @@
+---
+"@shopify/shopify-app-remix": patch
+---
+
+Update AppConfig type to Readonly. The config should not be modified after it is created.
+
diff --git a/packages/shopify-app-remix/src/server/shopify-app.ts b/packages/shopify-app-remix/src/server/shopify-app.ts
@@ -61,7 +61,7 @@ export function shopifyApp<
   Resources extends ShopifyRestResources,
   Storage extends SessionStorage,
   Future extends FutureFlagOptions = Config['future'],
->(appConfig: Config): ShopifyApp<Config> {
+>(appConfig: Readonly<Config>): ShopifyApp<Config> {
   const api = deriveApi(appConfig);
   const config = deriveConfig<Storage>(appConfig, api.config);
   const logger = overrideLogger(api.logger);