Merge pull request #584 from Shopify/liz/external-redirect-on-action

Fix a external redirects failing in actions
Shopify · Jan 18, 2024 · 7d90dcc · 7d90dcc
2 parents 3fdb8d3 + 4bbbd50
commit 7d90dcc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.changeset/brave-points-cross.md b/.changeset/brave-points-cross.md
@@ -0,0 +1,5 @@
+---
+'@shopify/shopify-app-remix': patch
+---
+
+Fixes a bug that was causing external redirects to fail in remix actions
diff --git a/packages/shopify-app-remix/src/server/authenticate/admin/helpers/redirect.ts b/packages/shopify-app-remix/src/server/authenticate/admin/helpers/redirect.ts
@@ -66,15 +66,11 @@ function isBounceRequest(request: Request) {
 }
 
 function isDataRequest(request: Request) {
-  const {searchParams} = new URL(request.url);
-
   const isGet = request.method === 'GET';
   const sessionTokenHeader = Boolean(getSessionTokenHeader(request));
-  const sessionTokenSearchParam = searchParams.has('id_token');
 
   return (
     sessionTokenHeader &&
-    !sessionTokenSearchParam &&
     !isBounceRequest(request) &&
     (!isEmbeddedRequest(request) || !isGet)
   );