Refactor manageAccessToken type

Shopify · Nov 15, 2023 · 4f2fbeb · 4f2fbeb
1 parent c6ac503
commit 4f2fbeb
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 11 deletions.
diff --git a/packages/shopify-app-remix/src/server/authenticate/admin/authenticate.ts b/packages/shopify-app-remix/src/server/authenticate/admin/authenticate.ts
@@ -135,7 +135,7 @@ export class AuthStrategy<
 
     const {sessionContext, shop} = await this.getAuthenticatedSession(request);
 
-    return this.strategy.manageAccessToken(sessionContext, shop, request);
+    return this.strategy.manageAccessToken({sessionContext, shop, request});
   }
 
   private async handleBouncePageRoute(request: Request) {

diff --git a/packages/shopify-app-remix/src/server/authenticate/admin/strategies/auth-code-flow.ts b/packages/shopify-app-remix/src/server/authenticate/admin/strategies/auth-code-flow.ts
@@ -54,11 +54,15 @@ export class AuthCodeFlowStrategy<
     }
   }
 
-  async manageAccessToken(
-    sessionContext: SessionContext | undefined,
-    shop: string,
-    request: Request,
-  ): Promise<SessionContext> {
+  async manageAccessToken({
+    sessionContext,
+    shop,
+    request,
+  }: {
+    sessionContext?: SessionContext;
+    shop: string;
+    request: Request;
+  }): Promise<SessionContext> {
     const {config, logger, api} = this;
     if (
       !sessionContext?.session ||

diff --git a/packages/shopify-app-remix/src/server/authenticate/admin/strategies/types.ts b/packages/shopify-app-remix/src/server/authenticate/admin/strategies/types.ts
@@ -2,10 +2,14 @@ import {SessionContext} from '../types';
 
 export interface AuthorizationStrategy {
   handleRoutes: (request: Request) => void;
-  manageAccessToken: (
-    sessionContext: SessionContext | undefined,
-    shop: string,
-    request: Request,
-  ) => Promise<SessionContext>;
+  manageAccessToken: ({
+    sessionContext,
+    shop,
+    request,
+  }: {
+    sessionContext?: SessionContext;
+    shop: string;
+    request: Request;
+  }) => Promise<SessionContext>;
   ensureInstalledOnShop: (request: Request) => void;
 }