PR Feedback:

1. Removed .only from two tests (oops)
2. Wrap example titles in <caption>
3. Make it clear in the tests the Request is cross origin

packages/shopify-app-remix/src/server/authenticate/public/__tests__/factory.test.ts

@@ -7,7 +7,7 @@ import {
 } from '../../../__test-helpers';
 
 describe('JWT validation', () => {
-  it.only('logs that the method is deprecated', async () => {
+  it('logs that the method is deprecated', async () => {
     // GIVEN
     const config = testConfig();
     const shopify = shopifyApp(config);
@@ -56,7 +56,7 @@ describe('JWT validation', () => {
 
     // WHEN
     const {cors} = await shopify.authenticate.public(
-      new Request('https://some-other.origin', {
+      new Request(APP_URL, {
         headers: {
           Origin: 'https://some-other.origin',
           Authorization: `Bearer ${token}`,
@@ -94,7 +94,7 @@ describe('JWT validation', () => {
     // GIVEN
     const shopify = shopifyApp(testConfig());
     const {token} = getJwt();
-    const request = new Request('https://some-other.origin', {
+    const request = new Request(APP_URL, {
       method: 'OPTIONS',
       headers: {
         Origin: 'https://some-other.origin',

packages/shopify-app-remix/src/server/authenticate/public/appProxy/__tests__/authenticate.test.ts

@@ -32,7 +32,7 @@ describe('authenticating app proxy requests', () => {
     expect(response.statusText).toBe('Bad Request');
   });
 
-  it.only('Throws a 400 response if the signature param is incorrect', async () => {
+  it('Throws a 400 response if the signature param is incorrect', async () => {
     // GIVEN
     const shopify = shopifyApp(testConfig());
 

packages/shopify-app-remix/src/server/authenticate/public/checkout/__tests__/authenticate.test.ts

@@ -32,7 +32,7 @@ describe('JWT validation', () => {
 
     // WHEN
     const {cors} = await shopify.authenticate.public.checkout(
-      new Request('https://some-other.origin', {
+      new Request(APP_URL, {
         headers: {
           Origin: 'https://some-other.origin',
           Authorization: `Bearer ${token}`,
@@ -70,7 +70,7 @@ describe('JWT validation', () => {
     // GIVEN
     const shopify = shopifyApp(testConfig());
     const {token} = getJwt();
-    const request = new Request('https://some-other.origin', {
+    const request = new Request(APP_URL, {
       method: 'OPTIONS',
       headers: {
         Origin: 'https://some-other.origin',

packages/shopify-app-remix/src/server/authenticate/public/checkout/types.ts

@@ -21,7 +21,7 @@ export interface CheckoutContext {
    * The payload of the Session Token is described here: {@link https://shopify.dev/docs/apps/auth/oauth/session-tokens#payload}
    *
    * @example
-   * Getting your app's store specific widget data using the session token
+   * <caption>Get store specific widget data using the session token</caption>
    * ```ts
    * // app/routes/public/widgets.ts
    * import { LoaderArgs, json } from "@remix-run/node";
@@ -42,7 +42,7 @@ export interface CheckoutContext {
    * A function that ensures the CORS headers are set correctly for the response
    *
    * @example
-   * Setting CORS headers for a public request
+   * <caption>Setting CORS headers for a public request</caption>
    * ```ts
    * // app/routes/public/widgets.ts
    * import { LoaderArgs, json } from "@remix-run/node";

packages/shopify-app-remix/src/server/authenticate/public/types.ts

@@ -24,7 +24,7 @@ export type AuthenticatePublic = AuthenticateCheckout & {
    * Authenticate a request from a checkout extension
    *
    * @example
-   * Authenticating a checkout extension request
+   * <caption>Authenticating a checkout extension request</caption>
    * ```ts
    * // app/routes/public/widgets.ts
    * import { LoaderArgs, json } from "@remix-run/node";
@@ -44,7 +44,7 @@ export type AuthenticatePublic = AuthenticateCheckout & {
    * Authenticate a request from an app proxy
    *
    * @example
-   * Authenticating an app proxy request
+   * <caption>Authenticating an app proxy request</caption>
    * ```ts
    * // app/routes/public/widgets.ts
    * import { LoaderArgs, json } from "@remix-run/node";