Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add support for PHP 8.3 #315

Closed

Conversation

lvanstrijland
Copy link

@lvanstrijland lvanstrijland commented Dec 20, 2023

WHY are these changes introduced?

PHP 8.3 is currently not supported due to the strict versioning in the composer file.

WHAT is this pull request doing?

Add support for PHP 8.3 and update unit tests due to deprecation.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

Laurens van Strijland added 2 commits December 20, 2023 08:31
- Fix unit tests due to deprecation in PHP 8.3
@shakaran
Copy link
Contributor

shakaran commented Feb 25, 2024

Any chance to get this merged soon @paulomarg @mkevinosullivan @Jan0707 @sle-c? Thanks for your time!

@jesseschutt jesseschutt mentioned this pull request Apr 8, 2024
@paulomarg
Copy link
Contributor

Hey folks, sorry for the very late response - this was addressed in #318 by changing that dependency to ^8.0 so any version under 9 works. It is available as of v5.3.0.

@paulomarg paulomarg closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants