initial commit: remove array filtering for params and add unit test

Shopify · Sep 23, 2024 · e9fca71 · e9fca71
1 parent 18d1d3f
commit e9fca71
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/Rest/Base.php b/src/Rest/Base.php
@@ -178,7 +178,6 @@ protected static function request(
 
         $client = new Rest($session->getShop(), $session->getAccessToken());
 
-        $params = array_filter($params);
         switch ($httpMethod) {
             case "get":
                 $response = $client->get(

diff --git a/tests/Clients/BaseRestResourceTest.php b/tests/Clients/BaseRestResourceTest.php
@@ -63,6 +63,24 @@ public function testFindsWithParam()
         $this->assertEquals([1, "attribute"], [$resource->id, $resource->attribute]);
     }
 
+    public function testCanUseFalseyParam()
+    {
+        $body = ["fake_resource" => ["id" => 1, "attribute" => "attribute"]];
+
+        $this->mockTransportRequests([
+            new MockRequest(
+                $this->buildMockHttpResponse(200, $body),
+                "{$this->prefix}/fake_resources/1.json?param=0",
+                "GET",
+                null,
+                ["X-Shopify-Access-Token: access-token"],
+            ),
+        ]);
+
+        $resource = FakeResource::find($this->session, 1, [ "param" => "0"]);
+        $this->assertEquals([1, "attribute"], [$resource->id, $resource->attribute]);
+    }
+
     public function testFindsResourceAndChildrenById()
     {
         $body = ["fake_resource" => [