fix: SameSite = none for cookies.

Shopify · Jul 1, 2024 · a3d9178 · a3d9178
1 parent ed791f3
commit a3d9178
Showing 1 changed file with 16 additions and 10 deletions.
diff --git a/src/Auth/OAuth.php b/src/Auth/OAuth.php
@@ -351,21 +351,27 @@ private static function setCookie(
             $cookieSet = setcookie(
                 $signatureCookie->getName(),
                 $signatureCookie->getValue(),
-                $signatureCookie->getExpire(),
-                "",
-                "",
-                $signatureCookie->isSecure(),
-                $signatureCookie->isHttpOnly(),
+                [
+                    'expires' => $signatureCookie->getExpire(),
+                    'path' => "",
+                    'domain' => "",
+                    'secure' => $signatureCookie->isSecure(),
+                    'httponly' => $signatureCookie->isHttpOnly(),
+                    'samesite' => "none"
+                ],
             );
 
             $cookieSet = $cookieSet && setcookie(
                 $cookie->getName(),
                 $cookie->getValue(),
-                $cookie->getExpire(),
-                "",
-                "",
-                $cookie->isSecure(),
-                $cookie->isHttpOnly(),
+                [
+                    'expires' => $signatureCookie->getExpire(),
+                    'path' => "",
+                    'domain' => "",
+                    'secure' => $signatureCookie->isSecure(),
+                    'httponly' => $signatureCookie->isHttpOnly(),
+                    'samesite' => "none"
+                ],
             );
             // @codeCoverageIgnoreEnd
         }