Include error message into HttpRequestError

Shopify · Apr 9, 2024 · 16f52ee · 16f52ee
1 parent a2a3fd1
commit 16f52ee
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 14 deletions.
diff --git a/.changeset/friendly-beers-melt.md b/.changeset/friendly-beers-melt.md
@@ -0,0 +1,5 @@
+---
+"@shopify/shopify-api": patch
+---
+
+Include error message into HttpRequestError
diff --git a/packages/shopify-api/lib/clients/admin/__tests__/admin_graphql_client.test.ts b/packages/shopify-api/lib/clients/admin/__tests__/admin_graphql_client.test.ts
@@ -276,18 +276,19 @@ describe('GraphQL client', () => {
       }
     }`;
 
-    queueError(
-      new FetchError(
-        `uri requested responds with an invalid redirect URL: http://test.com`,
-        'invalid-redirect',
-      ),
+    const fetchError = new FetchError(
+      `uri requested responds with an invalid redirect URL: http://test.com`,
+      'invalid-redirect',
     );
+    queueError(fetchError);
+    queueError(fetchError);
 
     const request = async () => {
       await client.request(query);
     };
 
     await expect(request).rejects.toThrow(HttpRequestError);
+    await expect(request).rejects.toThrow('invalid redirect');
   });
 
   it('allows overriding the API version', async () => {

diff --git a/packages/shopify-api/lib/clients/common.ts b/packages/shopify-api/lib/clients/common.ts
@@ -62,11 +62,9 @@ export function throwFailedRequest(
   response?: Response,
 ): never {
   if (typeof response === 'undefined') {
+    const message = body?.errors?.message ?? '';
     throw new ShopifyErrors.HttpRequestError(
-      'Http request error, no response available',
-      {
-        body,
-      },
+      `Http request error, no response available: ${message}`,
     );
   }
 

diff --git a/packages/shopify-api/lib/clients/storefront/__tests__/storefront_client.test.ts b/packages/shopify-api/lib/clients/storefront/__tests__/storefront_client.test.ts
@@ -181,17 +181,18 @@ describe('Storefront GraphQL client', () => {
       apiVersion: '2020-01' as any as ApiVersion,
     });
 
-    queueError(
-      new FetchError(
-        `uri requested responds with an invalid redirect URL: http://test.com`,
-        'invalid-redirect',
-      ),
+    const fetchError = new FetchError(
+      `uri requested responds with an invalid redirect URL: http://test.com`,
+      'invalid-redirect',
     );
+    queueError(fetchError);
+    queueError(fetchError);
 
     const request = async () => {
       await client.request(QUERY);
     };
 
     await expect(request).rejects.toThrow(HttpRequestError);
+    await expect(request).rejects.toThrow('invalid redirect');
   });
 });