Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitizes the input for the commitlint GH workflow. #167

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

gvarandas
Copy link
Contributor

@gvarandas gvarandas commented Apr 10, 2024

Description

Followed Github's recommendation on how to deal with insecure inputs.

Test plan

  • Failed GH worfkflow (it tried to execute the swiftlint command)
  • Fixed GH workflow (it correctly parses and sanitizes the string and passes it to the commitlint command unaltered.

Checklist

  • I have added a decision record entry, PR includes changes to monorepo setup that may require explanation N/A

@gvarandas gvarandas force-pushed the guil/gh-action-security branch 3 times, most recently from e88eb1f to 3dc3bba Compare April 10, 2024 21:04
@gvarandas gvarandas changed the title fix: readme typo" 1 && echo "I can run any command on this runner fix: sanitizes the input for the commitlint GH workflow. Apr 10, 2024
@gvarandas gvarandas self-assigned this Apr 10, 2024
@gvarandas gvarandas marked this pull request as ready for review April 10, 2024 21:08
@gvarandas gvarandas force-pushed the guil/gh-action-security branch 2 times, most recently from 311dccc to 4e1816f Compare April 10, 2024 21:19
@gvarandas gvarandas merged commit 3f953bd into main Apr 10, 2024
8 of 10 checks passed
@gvarandas gvarandas deleted the guil/gh-action-security branch April 10, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants