[WIP] Remove usage of useBreakpoints from <Banner> #10891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesstelford
force-pushed
the
responsive-props-not-use-breakpoint
branch
from
951333f to
0008cb6
Compare
jesstelford
force-pushed
the
remove-use-breakpoint
branch
from
a16d391 to
fc0de02
Compare
jesstelford
force-pushed
the
responsive-props-not-use-breakpoint
branch
from
0008cb6 to
e777305
Compare
jesstelford
force-pushed
the
remove-use-breakpoint
branch
from
fc0de02 to
43d4d2a
Compare
jesstelford
force-pushed
the
responsive-props-not-use-breakpoint
branch
from
e777305 to
acb1bcc
Compare
jesstelford
force-pushed
the
remove-use-breakpoint
branch
from
43d4d2a to
789fb19
Compare
jesstelford
force-pushed
the
responsive-props-not-use-breakpoint
branch
from
acb1bcc to
3cbf209
Compare
jesstelford
force-pushed
the
remove-use-breakpoint
branch
from
789fb19 to
ffe3298
Compare
jesstelford
force-pushed
the
responsive-props-not-use-breakpoint
branch
2 times, most recently
from
e274a87 to
551e9c5
Compare
jesstelford
force-pushed
the
remove-use-breakpoint
branch
from
ffe3298 to
278f693
Compare
jesstelford
force-pushed
the
responsive-props-not-use-breakpoint
branch
from
551e9c5 to
68a3864
Compare
jesstelford
force-pushed
the
remove-use-breakpoint
branch
from
278f693 to
29406f6
Compare
jesstelford
force-pushed
the
responsive-props-not-use-breakpoint
branch
from
68a3864 to
731328a
Compare
jesstelford
force-pushed
the
remove-use-breakpoint
branch
from
29406f6 to
84f59ce
Compare
|
Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically. If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed. |
aaronccasanova
force-pushed
the
responsive-props-not-use-breakpoint
branch
from
731328a to
f3a65b2
Compare
aaronccasanova
force-pushed
the
remove-use-breakpoint
branch
from
84f59ce to
81de969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10890
This PR removes all usages of useBreakpoints internally, allowing us to push the media query matching to CSS where it belongs for style props.