-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Frame] Add scrollbar width buffer onto Content (#11891)
### WHY are these changes introduced? Part of Shopify/polaris-internal#1379 Follow up to #11826, this change is still behind a feature flag. * Moving scrollbar buffer from main to content in `Frame` since we moved the scrollbar to just the content * updating `scroll` -> `auto` ensures the scrollbar doesn't show up when there isn't any scroll. ## Tophat [Spin](https://admin.web.web-npdr.sophie-schneider.us.spin.dev/store/shop1/products?selectedView=all) * turn on scrollbars always show in settings, shorten the window so the scrollbar hides and shows and make sure there isn't a layout shift  - [x] Chrome, Firefox, Safari - [x] Mobile
- Loading branch information
1 parent
a60d8aa
commit c84d4e8
Showing
3 changed files
with
28 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@shopify/polaris': patch | ||
--- | ||
|
||
Moved `Frame` scrollbar from main to content and set overflow-y from scroll to auto behind a feature flag |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters