Fix bar chart animation when sign changes #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
carysmills
force-pushed
the
bar-animation-fix
branch
2 times, most recently
from
9ad044d to
61ef633
Compare
carysmills
force-pushed
the
bar-animation-fix
branch
from
61ef633 to
d4ed8b3
Compare
envex
approved these changes
Dec 13, 2024
michaelnesen
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Improve the bar animation when the value changes from negative to positive for vice versa
Does this close any currently open issues?
Resolves https://github.com/Shopify/core-issues/issues/81906
What do the changes look like?
Screen.Recording.2024-12-13.at.8.49.11.AM.mov
Screen.Recording.2024-12-13.at.8.49.38.AM.mov
Storybook link
https://6062ad4a2d14cd0021539c1b-kipahzvwhw.chromatic.com/?path=/story/polaris-viz-charts-barchart--default
Note: I removed these changes in Storybook so they aren't on the PR
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package