Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update currencies #358

Merged
merged 18 commits into from
Feb 14, 2025
Merged

Update currencies #358

merged 18 commits into from
Feb 14, 2025

Conversation

elfassy
Copy link
Contributor

@elfassy elfassy commented Feb 5, 2025

Why

Maintain our list of currencies to be up to date

What

see each commit description. All changes are already live on RubyMoney https://github.com/RubyMoney/money/commits/main/config/currency_iso.json

On 2023-01-01, Croatia adopted the Euro and the HRK became obsolete.

https://economy-finance.ec.europa.eu/euro/eu-countries-and-euro/croatia-and-euro_en

This PR moves the definition of HRK to the backwards compatibility source file, consistent with other obsolete currencies.
A value in pesos is written with a preceding "$" sign only
https://en.wikipedia.org/wiki/Argentine_peso
@elfassy elfassy force-pushed the update_currency_list branch from bd5a489 to da6f1e2 Compare February 5, 2025 15:50
@elfassy elfassy requested a review from bslobodin February 5, 2025 15:50
@elfassy elfassy force-pushed the update_currency_list branch from da6f1e2 to 0ab6d42 Compare February 5, 2025 15:58
@elfassy elfassy requested a review from cialexander February 5, 2025 15:59
According to the ISO-4217 https://en.wikipedia.org/wiki/Currency_symbol and Bahraini dinar Wiki https://en.wikipedia.org/wiki/Bahraini_dinar the correct currency symbol for this Bahraini Dinar should be د.ب instead of ب.د
Georgian Lari symbol was changed back in 2014
More about it in the Wikipedia page: https://en.wikipedia.org/wiki/Georgian_lari
matches what rails expects
```
ActionController::Base.helpers.number_to_currency(12345, locale: :is)
=> "12.345 kr"
```
As of August 20, 2018, the official currency of Venezuela is VES (the bolívar soberano), replacing VEF (bolívar fuerte)

This helps make the symbols consistent
keep in sync with RubyMoney
@elfassy elfassy force-pushed the update_currency_list branch from 0ab6d42 to 15401d7 Compare February 14, 2025 14:50
Copy link
Member

@j-mutter j-mutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as per ISO 4217

@@ -905,20 +905,6 @@ hnl:
thousands_separator: ","
iso_numeric: '340'
smallest_denomination: 5
hrk:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by the Euro 👍🏼

@@ -1302,34 +1288,6 @@ lsl:
thousands_separator: ","
iso_numeric: '426'
smallest_denomination: 1
ltl:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by the Euro 👍🏼

thousands_separator: ","
iso_numeric: '440'
smallest_denomination: 1
lvl:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by the Euro 👍🏼

@elfassy elfassy merged commit df28cc5 into main Feb 14, 2025
7 checks passed
@elfassy elfassy deleted the update_currency_list branch February 14, 2025 17:02
@elfassy elfassy mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants