-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update currencies #358
Update currencies #358
Conversation
On 2023-01-01, Croatia adopted the Euro and the HRK became obsolete. https://economy-finance.ec.europa.eu/euro/eu-countries-and-euro/croatia-and-euro_en This PR moves the definition of HRK to the backwards compatibility source file, consistent with other obsolete currencies.
The disambiguate symbol "A-UM" has been added for MRO, see https://www.bcm.mr/IMG/pdf/directives_techniques.pdf
A value in pesos is written with a preceding "$" sign only https://en.wikipedia.org/wiki/Argentine_peso
bd5a489
to
da6f1e2
Compare
da6f1e2
to
0ab6d42
Compare
According to the ISO-4217 https://en.wikipedia.org/wiki/Currency_symbol and Bahraini dinar Wiki https://en.wikipedia.org/wiki/Bahraini_dinar the correct currency symbol for this Bahraini Dinar should be د.ب instead of ب.د
Georgian Lari symbol was changed back in 2014 More about it in the Wikipedia page: https://en.wikipedia.org/wiki/Georgian_lari
matches what rails expects ``` ActionController::Base.helpers.number_to_currency(12345, locale: :is) => "12.345 kr" ```
match ruby money RubyMoney/money#949
This is the "New Leone" introduced to Sierra Leone in July 2022 See: * https://www.reuters.com/article/leone-currency-idAFL8N2YI2E9 * https://en.wikipedia.org/w/index.php?title=ISO_4217&diff=1095269772&oldid=1095247155 * https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/amendments/dl_currency_iso_amendment_171.pdf
As of August 20, 2018, the official currency of Venezuela is VES (the bolívar soberano), replacing VEF (bolívar fuerte) This helps make the symbols consistent
keep in sync with RubyMoney
0ab6d42
to
15401d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as per ISO 4217
@@ -905,20 +905,6 @@ hnl: | |||
thousands_separator: "," | |||
iso_numeric: '340' | |||
smallest_denomination: 5 | |||
hrk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced by the Euro 👍🏼
@@ -1302,34 +1288,6 @@ lsl: | |||
thousands_separator: "," | |||
iso_numeric: '426' | |||
smallest_denomination: 1 | |||
ltl: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced by the Euro 👍🏼
thousands_separator: "," | ||
iso_numeric: '440' | ||
smallest_denomination: 1 | ||
lvl: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced by the Euro 👍🏼
Why
Maintain our list of currencies to be up to date
What
see each commit description. All changes are already live on RubyMoney https://github.com/RubyMoney/money/commits/main/config/currency_iso.json